Nixpkgs security tracker

Login with GitHub

Suggestion detail

Dismissed
(max. allowed matches exceeded)
created 4 hours ago Activity log
  • Created & dismissed (max. allowed matches exceeded) suggestion
module: decompress: check return value of module_extend_max_pages()

In the Linux kernel, the following vulnerability has been resolved: module: decompress: check return value of module_extend_max_pages() module_extend_max_pages() calls kvrealloc() internally and returns -ENOMEM on allocation failure. The return value is never checked. If the initial allocation fails, info->pages remains NULL and info->max_pages remains 0. Subsequent calls to module_get_next_page() will attempt to dynamically grow the array by calling module_extend_max_pages(info, 0) since info->used_pages is 0. This results in kvrealloc(NULL, 0) returning ZERO_SIZE_PTR, which is treated as a success, leading to a dereference of ZERO_SIZE_PTR and a kernel oops. Fix: add the missing error check after module_extend_max_pages() and return immediately on failure. This matches the pattern used by every other kvrealloc() caller in the module loading path. [Sami: Corrected the analysis in the commit message.]

Affected products

Linux
  • <e7f174715f9f0cbcb9e87b52e4fc4ef149baac98
  • =<6.18.*
  • <786d2d84416a9a1c1a47b71a68d679d886284be2
  • ==5.17
  • <e7da02659c229f73492fb1ed87ceda4090153aaa
  • =<6.12.*
  • <168072baf9ad516d5a06046514c7fea4c0671990
  • <5.17
  • =<7.1.*
  • =<6.1.*
  • <afcc0515bbdd28d509a2b5870faaa89b137f5d53
  • =<6.6.*
  • <a82e170637e050a803b4f37542371ef216bf66d2
  • =<*